From: Ævar Arnfjörð Bjarmason Date: Sat, 25 Sep 2010 10:26:48 GMT Subject: Re: [PATCH/RFC v2 2/4] rev-parse: Don't recognise --flags as an option if --no-flags has been specified. Message-ID: In-Reply-To: <1285405454-12521-4-git-send-email-jon.seymour@gmail.com> On Sat, Sep 25, 2010 at 09:04, Jon Seymour wrote: > +                               if (!(filter & DO_FLAGS)) { > +                                       // --preceding --no-flags means --flags is ignored > +                                       continue; > +                               } Please use a /* C89 comment */, not the C++ / C99 style.