git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add test-string-list.c

From
Thiago Farina <tfransosi@gmail.com>
Date
Sep 7, 2010, 12:04 UTC
Message-ID
<AANLkTi=1B6GaWZ0d6uiHWWjP7EvQLsaO0ZQDgWuBofDN@mail.gmail.com>
In-Reply-To
<20100907000703.GB32717@burratino>
On Mon, Sep 6, 2010 at 9:07 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 14 quoted lines
> Hi Thiago,
>
> Thiago Farina wrote:
>> On Sun, Sep 5, 2010 at 2:02 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:>
>
>>> To make sure this example remains valid, wouldn't you want to include
>>> a caller in the t/ directory so it can be automatically run?  (See
>>> t/README.)
>>
>> I read it, but I'm not sure how to do this. Maybe you could point me
>> to an example?
>
> t0070-fundamental.sh might be a good place to add it.
>
Thanks, added it to there.
>> It can be expanded later by anyone to test many other things though.
>
> I suppose.  Edge cases for arguments, sorting, and _DUP versus _NODUP
> semantics would be the main thing I would be interested in testing.

Reworked into small functions to test string_list functions separated (using assert to check if the return value of the function is what is expected).

Please, take another look.
Previous: Jonathan Nieder
Message 6 of 6 in “Add test-string-list.c”
  1. Add test-string-list.cThiago Farina, Sep 5, 2010
  2. Jonathan NiederSep 5, 2010
  3. Junio C HamanoSep 6, 2010
  4. Thiago FarinaSep 6, 2010
  5. Jonathan NiederSep 7, 2010
  6. Thiago FarinaSep 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.