From: Thiago Farina <tfransosi@gmail.com>
Date: Tue, 07 Sep 2010 12:04:45 GMT
Subject: Re: [PATCH] Add test-string-list.c
Message-ID: <AANLkTi=1B6GaWZ0d6uiHWWjP7EvQLsaO0ZQDgWuBofDN@mail.gmail.com>
In-Reply-To: <20100907000703.GB32717@burratino>

On Mon, Sep 6, 2010 at 9:07 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi Thiago,
>
> Thiago Farina wrote:
>> On Sun, Sep 5, 2010 at 2:02 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:>
>
>>> To make sure this example remains valid, wouldn't you want to include
>>> a caller in the t/ directory so it can be automatically run?  (See
>>> t/README.)
>>
>> I read it, but I'm not sure how to do this. Maybe you could point me
>> to an example?
>
> t0070-fundamental.sh might be a good place to add it.
>
Thanks, added it to there.

>> It can be expanded later by anyone to test many other things though.
>
> I suppose.  Edge cases for arguments, sorting, and _DUP versus _NODUP
> semantics would be the main thing I would be interested in testing.

Reworked into small functions to test string_list functions separated
(using assert to check if the return value of the function is what is
expected).

Please, take another look.