git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 1/2] fetch-prune: optimize dangling-ref reporting

From
Lidong Yan <yldhome2d2@gmail.com>
Date
Jun 19, 2025, 14:41 UTC
Message-ID
<A68FFEEC-0406-4280-BC7A-67C932141F41@gmail.com>
In-Reply-To
<B83B89F8-8129-445C-B4F5-43C86512C114@gmail.com>
Lidong Yan <yldhome2d2@gmail.com> writes:
Show 6 quoted lines
> 
> This patch only adds sorting code to prune_refs(), and as far as I can tell,
> prune_refs() is only called once during git fetch. So I was just wondering,
> would it be problematic if we moved the string_list_sort() into
> refs_warn_dangling_symref() instead? And if it turns out to be safe, could
> we perhaps even use strset in refs_warn_dangling_symref()?
Ah, sorry I make a mistake. We can’t sort string_list in refs_warn_dangling_symref().
Previous: Lidong YanNext: Phil Hord
Message 7 of 14 in “fetch --prune performance problem”
  1. 0/2 fetch --prune performance problemPhil Hord, Jun 18, 2025
  2. 1/2 fetch-prune: optimize dangling-ref reportingPhil Hord, Jun 18, 2025
  3. Junio C HamanoJun 18, 2025
  4. Jacob KellerJun 18, 2025
  5. Jeff KingJun 19, 2025
  6. Lidong YanJun 19, 2025
  7. Lidong YanJun 19, 2025
  8. 2/2 refs: remove old refs_warn_dangling_symrefPhil Hord, Jun 18, 2025
  9. Jacob KellerJun 18, 2025
  10. Jeff KingJun 19, 2025
  11. Junio C HamanoJun 19, 2025
  12. Jacob KellerJun 23, 2025
  13. Junio C HamanoJun 23, 2025
  14. Jacob KellerJun 23, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.