From: Lidong Yan <yldhome2d2@gmail.com>
Date: Thu, 19 Jun 2025 14:41:28 GMT
Subject: Re: [RFC PATCH 1/2] fetch-prune: optimize dangling-ref reporting
Message-ID: <A68FFEEC-0406-4280-BC7A-67C932141F41@gmail.com>
In-Reply-To: <B83B89F8-8129-445C-B4F5-43C86512C114@gmail.com>

Lidong Yan <yldhome2d2@gmail.com> writes：
> 
> This patch only adds sorting code to prune_refs(), and as far as I can tell,
> prune_refs() is only called once during git fetch. So I was just wondering,
> would it be problematic if we moved the string_list_sort() into
> refs_warn_dangling_symref() instead? And if it turns out to be safe, could
> we perhaps even use strset in refs_warn_dangling_symref()?

Ah, sorry I make a mistake. We can’t sort string_list in refs_warn_dangling_symref().