git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-grep: Fix problems with recently added tests

From
Brian Gernhardt <brian@gernhardtsoftware.com>
Date
May 26, 2011, 21:55 UTC
Message-ID
<A33A9CA5-B648-44AE-9B8E-7C27AB48FE54@gernhardtsoftware.com>
In-Reply-To
<1306446622-12784-1-git-send-email-michal.kiedrowicz@gmail.com>
On May 26, 2011, at 5:50 PM, Michał Kiedrowicz wrote:
Show 6 quoted lines
> test_expect_success 'grep -E -F -G pattern' '
> 	echo ab:aab >expected &&
> -	git grep -E -F -G a\\+b >actual &&
> +	git grep -E -F -G "aa*b" ab >actual &&
> 	test_cmp expected actual
> '
Wouldn't this also pass if -E was active instead of -G?  That's why I mentioned using a literal + in the pattern so that what -G and what -E would match would be different.
~~ Brian
Previous: Michał Kiedrowicz
Message 2 of 2 in “git-grep: Fix problems with recently added tests”
  1. git-grep: Fix problems with recently added testsMichał Kiedrowicz, May 26, 2011
  2. Brian GernhardtMay 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.