From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Thu, 26 May 2011 21:55:50 GMT
Subject: Re: [PATCH] git-grep: Fix problems with recently added tests
Message-ID: <A33A9CA5-B648-44AE-9B8E-7C27AB48FE54@gernhardtsoftware.com>
In-Reply-To: <1306446622-12784-1-git-send-email-michal.kiedrowicz@gmail.com>


On May 26, 2011, at 5:50 PM, Michał Kiedrowicz wrote:

> test_expect_success 'grep -E -F -G pattern' '
> 	echo ab:aab >expected &&
> -	git grep -E -F -G a\\+b >actual &&
> +	git grep -E -F -G "aa*b" ab >actual &&
> 	test_cmp expected actual
> '

Wouldn't this also pass if -E was active instead of -G?  That's why I mentioned using a literal + in the pattern so that what -G and what -E would match would be different.

~~ Brian