Re: Huge win, compressing a window of delta runs as a unit

From: Jon Smirl <jonsmirl@gmail.com>
Date: Aug 17, 2006, 18:06 UTC
Message-ID: <9e4733910608171106l74ee4d39x6e34900877c24bb0@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0608171323330.11359@localhost.localdomain>

On 8/17/06, Nicolas Pitre <nico@cam.org> wrote:

Show 15 quoted lines

> On Thu, 17 Aug 2006, Jon Smirl wrote:
>
> > Is there a pack format version number built into the server procotol?
> > If not there needs to be one. When there is a mismatch with the server
> > pack version the client should simply display an error requesting an
> > upgrade of the client software.
>
> There is a pack version number.  Reception of an unknown pack already
> produces an error:
>
>         if (!pack_version_ok(hdr->hdr_version))
>                 die("unknown pack file version %d", ntohl(hdr->hdr_version));
>
> That will occur really early in a pull or clone when using the native
> protocol.

Can this be fixed so that if the pack protocol coming from the server is greater than the one handled by the client. they client gets a nice hint about upgrading?

-- 
Jon Smirl
jonsmirl@gmail.com