Re: [PATCH v4] Doc: Bundle file usage
- From
Philip Oakley <philipoakley@iee.email>
- Date
- Oct 20, 2019, 10:49 UTC
- Message-ID
- <9e097bb2-ff3e-db5b-f0fd-0803e56b2cd6@iee.email>
- In-Reply-To
- <20191020011020.GA2980@sigill.intra.peff.net>
On 20/10/2019 02:10, Jeff King wrote:
Show 18 quoted lines
> On Fri, Oct 18, 2019 at 09:30:52PM +0100, Philip Oakley wrote: > >> +`git clone` can use any bundle created without negative refspecs >> +(e.g., `new`, but not `old..new`). >> +If you want to match `git clone --mirror`, which would clone other >> +refs such as `refs/remotes/*`, use `--all`. >> +If you want to provide the same set of refs that a clone directly >> +from the source repository would get, use `--branches --tags` for >> +the `<git-rev-list-args>`. > Since you swapped the order here of "--mirror" versus non-mirror, saying > "other refs such as..." in the first part is confusing. We haven't > introduced the thing they're "other" from. > > Maybe say "clone all refs (including ones which would be omitted by a > non-mirror clone, like refs/remotes/*)" or something? > > Other than that, this version looks OK to me. >
I had deliberately swapped the order because of the classic human fallibility of only remembering the beginning and end parts, so I'd buried' the --mirror/--all option, leaving that important bit to the end.
I'll probably simply just drop the word "other" (or maybe "include cloning")
Philip