Re: [PATCH v4] Doc: Bundle file usage

From: Jeff King <peff@peff.net>
Date: Oct 20, 2019, 01:10 UTC
Message-ID: <20191020011020.GA2980@sigill.intra.peff.net>
In-Reply-To: <20191018203052.2451-1-philipoakley@iee.email>

On Fri, Oct 18, 2019 at 09:30:52PM +0100, Philip Oakley wrote:

Show 7 quoted lines

> +`git clone` can use any bundle created without negative refspecs
> +(e.g., `new`, but not `old..new`).
> +If you want to match `git clone --mirror`, which would clone other
> +refs such as `refs/remotes/*`, use `--all`.
> +If you want to provide the same set of refs that a clone directly
> +from the source repository would get, use `--branches --tags` for
> +the `<git-rev-list-args>`.

Since you swapped the order here of "--mirror" versus non-mirror, saying "other refs such as..." in the first part is confusing. We haven't introduced the thing they're "other" from.

Maybe say "clone all refs (including ones which would be omitted by a non-mirror clone, like refs/remotes/*)" or something?

Other than that, this version looks OK to me.

-Peff