Re: [PATCH GSOC] diff: use conventional comparison order

From: Tian Yuchen <cat@malon.dev>
Date: Mar 13, 2026, 17:59 UTC
Message-ID: <9afe48e3-8348-4e2c-8e5f-bbdc3b2951f8@malon.dev>
In-Reply-To: <20260313140440.564201-1-ahambrahmasmi2357@gmail.com>

Hi aum2357,

On 3/13/26 22:04, aum2357 wrote:

Show 22 quoted lines

> diff: use conventional comparison order
> 
> Replace `0 <= addremove_explicit` with `addremove_explicit >= 0`
> to follow the common coding style where variables appear on the
> left side of comparisons.
> ---
>   builtin/add.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builtin/add.c b/builtin/add.c
> index 0ee21692c2..ad0d6047af 100644
> --- a/builtin/add.c
> +++ b/builtin/add.c
> @@ -432,7 +432,7 @@ int cmd_add(int argc,
>   	argc--;
>   	argv++;
>   
> -	if (0 <= addremove_explicit)
> +	if ( addremove_explicit >= 0 )
>   		addremove = addremove_explicit;
>   	else if (take_worktree_changes && ADDREMOVE_DEFAULT)
>   		addremove = 0; /* "-u" was given but not "-A" */

I guess this syntax is probably intended to prevent the compiler from not reporting an error when someone accidentally types '='. But since the code is already written and runs fine, isn't it a bit unnecessary to change it?

You can try a command like

> git grep -E ‘\(.*<=.*\)’

to see what happens. The codebase actually includes both, right?

By the way, as far as I know, no country allows numbers to be part of a name. In other word, I don't think 'aum2357' is your real name ;) If you've browsed the mailing list, you'll notice that everyone submits patches using their real names. Please adjust yours accordingly.

Regards,

Yuchen