Re: [PATCH GSOC] diff: use conventional comparison order
- From
Tian Yuchen <cat@malon.dev>
- Date
- Mar 14, 2026, 03:59 UTC
- Message-ID
- <405c075b-731b-47e3-9e9c-70aaa0efe1cc@malon.dev>
- In-Reply-To
- <xmqqldfv4h6k.fsf@gitster.g>
On 3/14/26 04:18, Junio C Hamano wrote:
> You guessed wrong. See CodingGuidelines.
It does have nothing to do with the compiler. Thanks for pointing out.
However, the coding guidelines state:
> Both are valid, and we use both.
So, the real key is this sentence:
> Just do not mix styles in the same part of the code and mimic > existing styles in the neighbourhood.
However, in builtin/add.c before the patch, there isn't even a single “>” symbol used for comparison. The “<” symbol is used throughout the comparison sections.
I find it quite strange because the author says:
> to follow the common coding style
This patch seems more like it breaks the common coding style.
Regards,
Yuchen