Re: What's cooking in git.git (Dec 2016, #08; Tue, 27)

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 29, 2016, 10:10 UTC
Message-ID: <9E13F972-F374-4126-A599-A8A7618D4AF3@gmail.com>
In-Reply-To: <xmqqy3z155o1.fsf@gitster.mtv.corp.google.com>

Show 16 quoted lines

> On 28 Dec 2016, at 00:11, Junio C Hamano <gitster@pobox.com> wrote:
> 
> 
> * bw/realpath-wo-chdir (2016-12-22) 5 commits
>  (merged to 'next' on 2016-12-22 at fea8fa870f)
> + real_path: canonicalize directory separators in root parts
> + real_path: have callers use real_pathdup and strbuf_realpath
> + real_path: create real_pathdup
> + real_path: convert real_path_internal to strbuf_realpath
> + real_path: resolve symlinks by hand
> (this branch is used by bw/grep-recurse-submodules.)
> 
> The implementation of "real_path()" was to go there with chdir(2)
> and call getcwd(3), but this obviously wouldn't be usable in a
> threaded environment.  Rewrite it to manually resolve relative
> paths including symbolic links in path components.

"real_path: resolve symlinks by hand" (05b458c) introduces "MAXSYMLINKS" which is already defined on macOS in

/usr/include/sys/param.h:197:9:

 * .., MAXSYMLINKS defines the
 * maximum number of symbolic links that may be expanded in a path name.
 * It should be set high enough to allow all legitimate uses, but halt
 * infinite loops reasonably quickly.
 */

Log with JS: https://travis-ci.org/git/git/jobs/187092215 Log without JS: https://s3.amazonaws.com/archive.travis-ci.org/jobs/187092215/log.txt

- Lars