git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Dec 2016, #08; Tue, 27)

From
BWBrandon Williams <bmwill@google.com>
Date
Jan 3, 2017, 18:54 UTC
Message-ID
<20170103185402.GC42671@google.com>
In-Reply-To
<9E13F972-F374-4126-A599-A8A7618D4AF3@gmail.com>
On 12/29, Lars Schneider wrote:
Show 35 quoted lines
> 
> > On 28 Dec 2016, at 00:11, Junio C Hamano <gitster@pobox.com> wrote:
> > 
> > 
> > * bw/realpath-wo-chdir (2016-12-22) 5 commits
> >  (merged to 'next' on 2016-12-22 at fea8fa870f)
> > + real_path: canonicalize directory separators in root parts
> > + real_path: have callers use real_pathdup and strbuf_realpath
> > + real_path: create real_pathdup
> > + real_path: convert real_path_internal to strbuf_realpath
> > + real_path: resolve symlinks by hand
> > (this branch is used by bw/grep-recurse-submodules.)
> > 
> > The implementation of "real_path()" was to go there with chdir(2)
> > and call getcwd(3), but this obviously wouldn't be usable in a
> > threaded environment.  Rewrite it to manually resolve relative
> > paths including symbolic links in path components.
> 
> "real_path: resolve symlinks by hand" (05b458c) introduces
> "MAXSYMLINKS" which is already defined on macOS in
> 
> /usr/include/sys/param.h:197:9:
> 
>  * .., MAXSYMLINKS defines the
>  * maximum number of symbolic links that may be expanded in a path name.
>  * It should be set high enough to allow all legitimate uses, but halt
>  * infinite loops reasonably quickly.
>  */
> 
> 
> Log with JS: https://travis-ci.org/git/git/jobs/187092215
> Log without JS: https://s3.amazonaws.com/archive.travis-ci.org/jobs/187092215/log.txt
> 
> - Lars
> 

Simple fix would be to just revert MAXSYMLINKS to be MAXDEPTH (which is what the #define was before this series). I'll resend the series with that fix.

-- 
Brandon Williams
Previous: Lars Schneider
Message 7 of 7 in “What's cooking in git.git (Dec 2016, #08; Tue, 27)”
  1. Junio C HamanoDec 27, 2016
  2. Brandon WilliamsDec 28, 2016
  3. Duy NguyenDec 29, 2016
  4. Duy NguyenJan 3, 2017
  5. Brandon WilliamsJan 3, 2017
  6. Lars SchneiderDec 29, 2016
  7. Brandon WilliamsJan 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.