Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

From: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date: Oct 10, 2016, 16:37 UTC
Message-ID: <9A250ABE-1B54-4AD4-8DB5-026CC4725AB9@apple.com>
In-Reply-To: <20161010131041.lpdh4a7nol24hsz2@sigill.intra.peff.net>

Show 15 quoted lines

> On Oct 10, 2016, at 06:10, Jeff King <peff@peff.net> wrote:
> 
> On Sun, Oct 09, 2016 at 07:53:23PM -0700, Jeremy Huddleston Sequoia wrote:
> 
>> Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better
>> handle distro changes to DEF_VER
>> 
>> Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae
>> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
> 
> I see there was a discussion elsewhere on the list about exactly what
> you are putting into DEF_VAR that causes the problem. Perhaps the commit
> message here would be a good place to mention that, why the current
> regex breaks it, and why your new version fixes not only it, but other
> possible values of DEF_VAR.

Thanks, I've added this blurb:

For example, git distributed with Apple's Xcode reports a version like:
    git version 2.9.3 (Apple Git-75)

Apple started doing this to help customers distinguish between different versions of their packaged git which have the same base version (eg: with different patches applied).