git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

From
Jeff King <peff@peff.net>
Date
Oct 10, 2016, 13:10 UTC
Message-ID
<20161010131041.lpdh4a7nol24hsz2@sigill.intra.peff.net>
In-Reply-To
<20161010025323.9415-1-jeremyhu@apple.com>
On Sun, Oct 09, 2016 at 07:53:23PM -0700, Jeremy Huddleston Sequoia wrote:
Show 5 quoted lines
> Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better
>  handle distro changes to DEF_VER
>
> Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae
> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

I see there was a discussion elsewhere on the list about exactly what you are putting into DEF_VAR that causes the problem. Perhaps the commit message here would be a good place to mention that, why the current regex breaks it, and why your new version fixes not only it, but other possible values of DEF_VAR.

-Peff
Previous: Jeremy Huddleston SequoiaNext: Jeremy Huddleston Sequoia
Message 4 of 9 in “t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER”
  1. t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VERJeremy Huddleston Sequoia, Oct 10, 2016
  2. Josh TriplettOct 10, 2016
  3. Jeremy Huddleston SequoiaOct 10, 2016
  4. Jeff KingOct 10, 2016
  5. Jeremy Huddleston SequoiaOct 10, 2016
  6. Junio C HamanoOct 10, 2016
  7. Junio C HamanoOct 10, 2016
  8. Jeremy Huddleston SequoiaOct 10, 2016
  9. Eric WongOct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.