Re: [PATCH v4 5/8] maintenance: add start/stop subcommands

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 10, 2020, 01:52 UTC
Message-ID: <995da636-94bc-378b-83d0-ecce9d802b81@gmail.com>
In-Reply-To: <xmqqtusuzffv.fsf@gitster.c.googlers.com>

On 12/9/2020 7:13 PM, Junio C Hamano wrote:

Show 8 quoted lines

> Josh Steadmon <steadmon@google.com> writes:
> 
>>  	# start registers the repo
>> -	git config --get --global maintenance.repo "$(pwd)" &&
>> +	git config --get --global --fixed-value maintenance.repo "$(pwd)" &&
> 
> The rewrite makes it better than the original, but I wonder why the
> original did not do a more obvious

maintenance.repo is a multi-valued config setting, so it is possible that there are multiple existing values. Hence the reason for needing the value filter.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.