Re: [PATCH v2 6/7] maintenance: recommended schedule in register/start

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Oct 2, 2020, 00:38 UTC
Message-ID: <20201002003844.GA28643@danh.dev>
In-Reply-To: <3e18199a-1dcb-057d-4753-03d5acfcc036@gmail.com>

On 2020-10-01 16:38:48-0400, Derrick Stolee <stolee@gmail.com> wrote:

Show 13 quoted lines

> diff --git a/Documentation/git-maintenance.txt b/Documentation/git-maintenance.txt
> index 7628a6d157..52fff86844 100644
> --- a/Documentation/git-maintenance.txt
> +++ b/Documentation/git-maintenance.txt
> @@ -37,6 +37,21 @@ register::
>  	`maintenance.<task>.schedule`. The tasks that are enabled are safe
>  	for running in the background without disrupting foreground
>  	processes.
> ++
> +If your repository has no `maintenance.<task>.schedule` configuration
> +values set, then Git will use a recommended default schedule that performs
> +background maintenance that will not interrupt foreground commands. The
> +default schedule is as follows:

I don't mind about using a default schedule (but someone else might). I think some distributions will be paranoia with this change and shiped with disable by default in system config.

> ++
> +* `gc`: disabled.
> +* `commit-graph`: hourly.
> +* `prefetch`: hourly.

However, no `prefetch` in default schedule, please. IIUC, this is a network operation, if someone is on the go and paying their internet based on their traffic, this will be a disaster.

> +* `loose-objects`: daily.
> +* `incremental-repack`: daily.

And I would say no incremental-repack, too. Users don't want to a large operation of IO on some random time of the day, be it when they open their PC in the morning, or when they want to close their laptop to go home.

----------(Windows rant ahead) I still remember those days that Windows 8 was introduced, Back in that days, my computer still uses the old 7200rpm HDD. I was super-angry that whenever Windows is started, it starts some IO disk-caching, indexing that hung my computer for a good 10 minutes. While that same computer can run Windows 7 and other OS fine. I don't particularly care how much my computer is faster after that. I want my computer usable at that time, instead of wasting a good 10 minutes on nothing. ---------(Windows rant end)

Either the users know what are they doing, or we don't do anything at all. Let's them do it on their free time.

IOW, Please let users opt in instead of opt out of this features.

-- 
Danh