git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Why is ident_is_sufficient different on Windows?

From
Max Horn <max@quendi.de>
Date
Feb 6, 2013, 13:06 UTC
Message-ID
<991CBC1C-912C-4DD6-B911-93F6B41D895E@quendi.de>
Hi there,
while trying to understand which parts of the author & committer identity are mandatory (name, email, or both), I ended up in ident.c, looking at ident_is_sufficient(), and to my surprise discovered that this seems to differ between Windows (were both are mandatory) and everyone else:
static int ident_is_sufficient(int user_ident_explicitly_given)
{
#ifndef WINDOWS
	return (user_ident_explicitly_given & IDENT_MAIL_GIVEN);
#else
	return (user_ident_explicitly_given == IDENT_ALL_GIVEN);
#endif
}
According to git blame, this was introduced here:
commit 5aeb3a3a838b2cb03d250f3376cf9c41f4d4608e
Author: Junio C Hamano <gitster@pobox.com>
Date:   Sun Jan 17 13:54:28 2010 -0800
    user_ident_sufficiently_given(): refactor the logic to be usable from elsewhere
The commit message sounds as if this was only a refactoring, but the patch to me look as if it changes behaviour, too. Of course this could very well be false, say due to code elsewhere that already caused Windows to behave differently; I wouldn't know.
Still, I wonder: Why does this difference exist?

Cheers, Max

Next: Junio C Hamano
Message 1 of 4 in “Why is ident_is_sufficient different on Windows?”
  1. Max HornFeb 6, 2013
  2. Junio C HamanoFeb 6, 2013
  3. Junio C HamanoFeb 6, 2013
  4. Junio C HamanoFeb 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.