git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Why is ident_is_sufficient different on Windows?

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 6, 2013, 20:52 UTC
Message-ID
<7vbobxb1wo.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vip65b25c.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> I suspect somebody from the Windows camp saw a patch I posted
>> without the ifdef, noticed that there is a problem to expect
>> IDENT_NAME_GIVEN to be set on Windows for some reason, and resulted
>> in a reroll of the function in that shape.
>>
>> I didn't find anything in the list archive, though.  So I am
>> stumped.
>
> The only thing I can think of is that on Unix we can guess name from
> GECOS, which could be considered sufficiently your name, while on
> Windows we probably do not get anything useful there.
http://thread.gmane.org/gmane.comp.version-control.git/137312/focus=137345

These days, we encourage setting user.name explicitly even on a system on which it is likely that we will see a good GECOS value, so removing the ifdef and always check with ALL may not hurt anybody. I dunno.

Previous: Junio C Hamano
Message 4 of 4 in “Why is ident_is_sufficient different on Windows?”
  1. Max HornFeb 6, 2013
  2. Junio C HamanoFeb 6, 2013
  3. Junio C HamanoFeb 6, 2013
  4. Junio C HamanoFeb 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.