Re: [PATCH v3 08/11] strbuf: introduce strbuf_strip_file_from_path()

From: Derrick Stolee <derrickstolee@github.com>
Date: Dec 7, 2022, 14:44 UTC
Message-ID: <98ee4b5b-9d72-31fc-d5b1-1a978450973f@github.com>
In-Reply-To: <221206.86wn74bw35.gmgdl@evledraar.gmail.com>

On 12/6/22 6:37 AM, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> FWIW the "overkill" change on top to do this via callbacks is the
> below. Which I tested just to see how easy it was, and whether it would
> fail your tests (it doesn't).
> 
> -- >8 --
> Subject: [PATCH] strbuf: generalize "{,r,l}trim" to a callback interface

I don't like this approach and think it distracts from the goal of the series. If you want to update it afterwards, then by all means go for it.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.