Re: [PATCH] test-bundle-uri: drop unused variables
On 1/6/2023 3:48 AM, Jeff King wrote:
Show 16 quoted lines
> On Thu, Jan 05, 2023 at 02:09:34PM -0500, Derrick Stolee wrote:
>
>>> Not a huge deal, but I noticed that Coverity complained about the
>>> uploadpack one because this hit 'next' (the server_options one I found
>>> manually, but it was kind of obvious when looking at the other).
>>
>> Yes, removing these lines would be fine. Perhaps there were
>> uses for these in an earlier version that were dropped. But
>> we can remove them now and then add them back when they
>> actually connect to functionality.
>
> Thanks for confirming. Here's a patch that can go on top of
> ds/bundle-uri-4 (or just on master, as that topic has now graduated).
>
> -- >8 --
> Subject: [PATCH] test-bundle-uri: drop unused variables
Thanks for putting together a formal patch. LGTM.
-Stolee