Re: [PATCH v2] gitk, git-gui: drop msgfmt --statistics output
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jun 21, 2026, 13:00 UTC
- Message-ID
- <98718401-9ff4-4b1a-97c7-71f8b6639fea@kdbg.org>
- In-Reply-To
- <pull.2339.v2.git.git.1781995570677.gitgitgadget@gmail.com>
Am 21.06.26 um 00:46 schrieb Harald Nordgren via GitGitGadget:
Show 24 quoted lines
> From: Harald Nordgren <haraldnordgren@gmail.com> > > The catalog rules ran msgfmt with --statistics, whose output went to > stderr and so survived "make -s" (gitk also echoed "Generating > catalog"). > > The statistics are not needed, as in 2f12b31b746c (Makefile: don't > invoke msgfmt with --statistics, 2021-12-17), and the "Generating > catalog" line is not needed either. Remove them so a quiet build stays > quiet. > diff --git a/gitk-git/Makefile b/gitk-git/Makefile > index 41116d8a14..0ae083c1ca 100644 > --- a/gitk-git/Makefile > +++ b/gitk-git/Makefile > @@ -75,8 +75,7 @@ update-po:: $(PO_TEMPLATE) > echo; \ > echo " git config filter.gettext-no-location.clean \"msgcat --no-location -\"" > $(ALL_MSGFILES): %.msg : %.po > - @echo Generating catalog $@ > - $(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $< > + $(MSGFMT) --tcl -l $(basename $(notdir $<)) -d $(dir $@) $< > > .PHONY: all install uninstall clean update-po > .PHONY: FORCE
This Gitk part doesn't make the build silent, yet. It misses the "if -s is in the flags" bracket.
It do not mind doing both (removing --statistics and make it silent) in a single patch.
BTW, please write commit message in the usual style, in particular, describe the status quo in present tense, not past tense.
Please bear in mind that Git, Gitk and Git GUI are tracked in different repositories. Do not put changes to multiple of these into a single commit/patch.
-- Hannes