git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] gitk, git-gui: drop msgfmt --statistics output

From
Johannes Sixt <j6t@kdbg.org>
Date
Jun 21, 2026, 13:00 UTC
Message-ID
<98718401-9ff4-4b1a-97c7-71f8b6639fea@kdbg.org>
In-Reply-To
<pull.2339.v2.git.git.1781995570677.gitgitgadget@gmail.com>
Am 21.06.26 um 00:46 schrieb Harald Nordgren via GitGitGadget:
Show 24 quoted lines
> From: Harald Nordgren <haraldnordgren@gmail.com>
> 
> The catalog rules ran msgfmt with --statistics, whose output went to
> stderr and so survived "make -s" (gitk also echoed "Generating
> catalog").
> 
> The statistics are not needed, as in 2f12b31b746c (Makefile: don't
> invoke msgfmt with --statistics, 2021-12-17), and the "Generating
> catalog" line is not needed either. Remove them so a quiet build stays
> quiet.
> diff --git a/gitk-git/Makefile b/gitk-git/Makefile
> index 41116d8a14..0ae083c1ca 100644
> --- a/gitk-git/Makefile
> +++ b/gitk-git/Makefile
> @@ -75,8 +75,7 @@ update-po:: $(PO_TEMPLATE)
>  	echo; \
>  	echo "	git config filter.gettext-no-location.clean \"msgcat --no-location -\""
>  $(ALL_MSGFILES): %.msg : %.po
> -	@echo Generating catalog $@
> -	$(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<
> +	$(MSGFMT) --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<
>  
>  .PHONY: all install uninstall clean update-po
>  .PHONY: FORCE

This Gitk part doesn't make the build silent, yet. It misses the "if -s is in the flags" bracket.

It do not mind doing both (removing --statistics and make it silent) in a single patch.

BTW, please write commit message in the usual style, in particular, describe the status quo in present tense, not past tense.

Please bear in mind that Git, Gitk and Git GUI are tracked in different repositories. Do not put changes to multiple of these into a single commit/patch.

-- Hannes
Previous: Johannes SixtNext: Harald Nordgren
Message 8 of 21 in “Silence po catalog output under "make -s"”
  1. 0/2 Silence po catalog output under "make -s"Harald Nordgren via GitGitGadget, Jun 14, 2026
  2. 1/2 gitk: silence catalog output under "make -s"Harald Nordgren via GitGitGadget, Jun 14, 2026
  3. 2/2 git-gui: silence statistics under "make -s"Harald Nordgren via GitGitGadget, Jun 14, 2026
  4. Harald NordgrenJun 15, 2026
  5. Johannes SixtJun 20, 2026
  6. gitk, git-gui: drop msgfmt --statistics outputHarald Nordgren via GitGitGadget, Jun 20, 2026
  7. 2/1 git-gui: reduce complexity of the quiet msgfmt ruleJohannes Sixt, Jun 21, 2026
  8. Johannes SixtJun 21, 2026
  9. Harald NordgrenJun 21, 2026
  10. Johannes SixtJun 21, 2026
  11. Harald NordgrenJun 21, 2026
  12. Johannes SixtJun 21, 2026
  13. 0/2 Silence po catalog output under "make -s"Harald Nordgren via GitGitGadget, Jun 21, 2026
  14. 1/2 gitk: make "make -s" silentHarald Nordgren via GitGitGadget, Jun 21, 2026
  15. 2/2 git-gui: silence statistics under "make -s"Harald Nordgren via GitGitGadget, Jun 21, 2026
  16. Johannes SixtJun 23, 2026
  17. Harald NordgrenJun 26, 2026
  18. Johannes SixtJun 27, 2026
  19. Junio C HamanoJun 28, 2026
  20. Harald NordgrenJul 12, 2026
  21. Junio C HamanoJul 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.