git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/2] gitk: make "make -s" silent

From
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
Date
Jun 21, 2026, 14:56 UTC
Message-ID
<4d977d6f3fe716e8b3d5655b010fedbb8c9b8960.1782053803.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2339.v3.git.git.1782053803.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>

The catalog rule runs msgfmt with --statistics, whose output goes to stderr and so survives "make -s", and the rule also echoes "Generating catalog". The Gitk Makefile guards its quiet helpers on V alone, so a silent build still prints these and the GEN line.

The statistics are not needed, as in 2f12b31b746c (Makefile: don't invoke msgfmt with --statistics, 2021-12-17). Drop them, suppress the quiet helpers when "s" is among the make flags, and give the catalog rule a quiet prefix so a quiet build stays quiet.

Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
 gitk-git/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gitk-git/Makefile b/gitk-git/Makefile
index 41116d8a14..dd87f501e5 100644
--- a/gitk-git/Makefile
+++ b/gitk-git/Makefile
@@ -43,9 +43,12 @@ PO_TEMPLATE = po/gitk.pot
 ALL_POFILES = $(wildcard po/*.po)
 ALL_MSGFILES = $(subst .po,.msg,$(ALL_POFILES))
 
+ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s)
 ifndef V
 	QUIET          = @
 	QUIET_GEN      = $(QUIET)echo '   ' GEN $@ &&
+	QUIET_MSGFMT   = $(QUIET)echo '   ' MSGFMT $@ &&
+endif
 endif
 
 all:: gitk-wish $(ALL_MSGFILES)
@@ -75,8 +78,7 @@ update-po:: $(PO_TEMPLATE)
 	echo; \
 	echo "	git config filter.gettext-no-location.clean \"msgcat --no-location -\""
 $(ALL_MSGFILES): %.msg : %.po
-	@echo Generating catalog $@
-	$(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<
+	$(QUIET_MSGFMT)$(MSGFMT) --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<
 
 .PHONY: all install uninstall clean update-po
 .PHONY: FORCE
-- 
gitgitgadget
Previous: Harald Nordgren via GitGitGadgetNext: Harald Nordgren via GitGitGadget
Message 14 of 21 in “Silence po catalog output under "make -s"”
  1. 0/2 Silence po catalog output under "make -s"Harald Nordgren via GitGitGadget, Jun 14, 2026
  2. 1/2 gitk: silence catalog output under "make -s"Harald Nordgren via GitGitGadget, Jun 14, 2026
  3. 2/2 git-gui: silence statistics under "make -s"Harald Nordgren via GitGitGadget, Jun 14, 2026
  4. Harald NordgrenJun 15, 2026
  5. Johannes SixtJun 20, 2026
  6. gitk, git-gui: drop msgfmt --statistics outputHarald Nordgren via GitGitGadget, Jun 20, 2026
  7. 2/1 git-gui: reduce complexity of the quiet msgfmt ruleJohannes Sixt, Jun 21, 2026
  8. Johannes SixtJun 21, 2026
  9. Harald NordgrenJun 21, 2026
  10. Johannes SixtJun 21, 2026
  11. Harald NordgrenJun 21, 2026
  12. Johannes SixtJun 21, 2026
  13. 0/2 Silence po catalog output under "make -s"Harald Nordgren via GitGitGadget, Jun 21, 2026
  14. 1/2 gitk: make "make -s" silentHarald Nordgren via GitGitGadget, Jun 21, 2026
  15. 2/2 git-gui: silence statistics under "make -s"Harald Nordgren via GitGitGadget, Jun 21, 2026
  16. Johannes SixtJun 23, 2026
  17. Harald NordgrenJun 26, 2026
  18. Johannes SixtJun 27, 2026
  19. Junio C HamanoJun 28, 2026
  20. Harald NordgrenJul 12, 2026
  21. Junio C HamanoJul 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.