Re: [PATCH 2/3] git config: clarify bool types
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Oct 12, 2009, 17:14 UTC
- Message-ID
- <94a0d4530910121014k666207b9ub38fcecd47641ace@mail.gmail.com>
- In-Reply-To
- <4AD3216B.7030507@drmicha.warpmail.net>
On Mon, Oct 12, 2009 at 3:30 PM, Michael J Gruber <git@drmicha.warpmail.net> wrote:
Show 15 quoted lines
> Felipe Contreras venit, vidit, dixit 12.10.2009 12:03:
>> On Mon, Oct 12, 2009 at 8:01 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> The value is what it is, the --bool and --bool-or-int options don't
>>>> specify the value type, just how it is interpreted. For example: a value
>>>> of '1' can be interpreted as 'true'.
>>>
>>> It is not really about "interpreting", but about showing, isn't it?
>>
>> Unless you are setting it, instead of reading it.
>>
>
> I'd still suggest fixing the typo ("interpreted") and spelling out
> "boolean".Oops! You mean s/intepreted/interpreted/?
If we spell 'boolean' we might as well spell 'integer'; I think bool and int are fine.
-- Felipe Contreras