Re: [PATCH 2/3] git config: clarify bool types

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Oct 13, 2009, 07:09 UTC
Message-ID: <4AD427AD.3010701@drmicha.warpmail.net>
In-Reply-To: <94a0d4530910121014k666207b9ub38fcecd47641ace@mail.gmail.com>

Felipe Contreras venit, vidit, dixit 12.10.2009 19:14:

Show 19 quoted lines

> On Mon, Oct 12, 2009 at 3:30 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> Felipe Contreras venit, vidit, dixit 12.10.2009 12:03:
>>> On Mon, Oct 12, 2009 at 8:01 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>>
>>>>> The value is what it is, the --bool and --bool-or-int options don't
>>>>> specify the value type, just how it is interpreted. For example: a value
>>>>> of '1' can be interpreted as 'true'.
>>>>
>>>> It is not really about "interpreting", but about showing, isn't it?
>>>
>>> Unless you are setting it, instead of reading it.
>>>
>>
>> I'd still suggest fixing the typo ("interpreted") and spelling out
>> "boolean".
> 
> Oops! You mean s/intepreted/interpreted/?

Yep :)

> 
> If we spell 'boolean' we might as well spell 'integer'; I think bool
> and int are fine.
>

"int" is at least a standard type name in C, whereas "bool" is not; but, yes, feel free to spell out "integer", or use "--int or --bool" as it is, which is a back reference to the corresponding entries for "--int" and "--bool", where things should be spelled out.

Michael