Re: [PATCH v3 0/2] Re: user-manual: general improvements

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 21, 2009, 16:00 UTC
Message-ID: <94a0d4530905210900xa464f75se2bd2bf3d8103b10@mail.gmail.com>
In-Reply-To: <7vvdnubl1x.fsf@alter.siamese.dyndns.org>

On Thu, May 21, 2009 at 5:14 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>> Maybe this was even discussed earlier in the thread (I didn't go back to
>>> look), but it should definitely be part of the commit message.
>>
>> The rule I followed is: change it to whatever looks best.
>
> "Looks best to me" is not something other people can follow to replicate
> the examples you set here to further "clean up" other parts of the
> documentation set or writing new sections to the document you touched up
> with this patch.
>
> I suspect that you would not deny the possibility of saying "The result
> looked better when I last looked at it, but now I think about it I do not
> know why I thought it looked better" three months down the line.
>
> It is not a rule.

The "guidelines" (not rules) I followed are a bit hard to explain, I'll try to do that, but in the meantime would you deny that the patch actually makes things a bit more consistent?

-- 
Felipe Contreras