git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] Re: user-manual: general improvements

From
Junio C Hamano <gitster@pobox.com>
Date
May 21, 2009, 05:18 UTC
Message-ID
<7viqjvdofq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090521041529.GD8091@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 38 quoted lines
> On Wed, May 20, 2009 at 06:33:36PM -0700, Junio C Hamano wrote:
>
>> >> http://people.freedesktop.org/~felipec/git/user-manual-general-improvements/
>> >
>> > Thank you very much Felipe to take the time to upload the patches there.
>> > I already have a copy there and I'll look at it soon.
>> 
>> Has anybody looked at this?  It's a bit large-ish and touches all over the
>> place, so I am finding it a bit hard to concentrate on it myself really
>> nitpicking, but from the cursory look after formatting the result looked
>> Ok.
>
> I started to, but the first commit message is lacking something that I
> think would make reviewing much simpler: what are the general classes of
> changes that are being made?
>
> I see some doublequotes becoming backticks, and some becoming single
> quotes. And some becoming tex-quotes (``...''), and even some becoming
> doublequotes _with_ single quotes. It would be easier to verify that
> they are doing the right thing if the commit message briefly described
> the rules it followed for changing each one. I think they are something
> like:
>
>   - tex-quotes if it was really a prose-style quotation
>
>   - backticks (causing monospace) for branch names, commands, etc in
>     prose
>
> but that leaves me confused. Some things which I thought should be in
> monospace backticks are in single-quotes (causing emphasis). Like
> 'master' or 'linux-2.6'. And some things are emphasized and in double
> quotes in the prose, like '"o"' or '"branch A"'. What is the rule to
> decide which text should have visible doublequotes but also be
> emphasized, as opposed to just having double-quotes or just being
> emphasized?
>
> Maybe this was even discussed earlier in the thread (I didn't go back to
> look), but it should definitely be part of the commit message.

I do not think there was any discussion, as the original patch never made to the list. And I realize that the difficulty I had while reading this was exactly what you described here. Thanks for saying it very clearly.

Previous: Jeff KingNext: Felipe Contreras
Message 7 of 17 in “user-manual: general improvements”
  1. 0/2 user-manual: general improvementsFelipe Contreras, May 6, 2009
  2. 0/2 Re: user-manual: general improvementsNicolas Sebrecht, May 7, 2009
  3. Junio C HamanoMay 8, 2009
  4. 2/2 user-manual: use 'fast-forward' instead of 'fast forward'Felipe Contreras, May 6, 2009
  5. Junio C HamanoMay 21, 2009
  6. Jeff KingMay 21, 2009
  7. Junio C HamanoMay 21, 2009
  8. Felipe ContrerasMay 21, 2009
  9. 0/2 Re: user-manual: general improvementsNicolas Sebrecht, May 21, 2009
  10. Felipe ContrerasMay 21, 2009
  11. Wincent ColaiutaMay 21, 2009
  12. Michael J GruberMay 21, 2009
  13. Felipe ContrerasMay 21, 2009
  14. Michael J GruberMay 25, 2009
  15. Junio C HamanoMay 21, 2009
  16. Felipe ContrerasMay 21, 2009
  17. Junio C HamanoMay 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.