Re: [PATCH 0/3] log: prettier decorations

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 13, 2009, 21:34 UTC
Message-ID: <94a0d4530905131434q17743408p5bc4b1c2fc332ea@mail.gmail.com>
In-Reply-To: <20090513212812.GA21268@coredump.intra.peff.net>

On Thu, May 14, 2009 at 12:28 AM, Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

> On Thu, May 14, 2009 at 12:22:03AM +0300, Felipe Contreras wrote:
>
>> In order to do that I had to change prettify_ref to prettify_refname because
>> add_ref_decoration doesn't have the ref object.
>
> Thanks, this 1/3 looks fine to me.
>
> But:
>
>> Felipe Contreras (3):
>>   Change prettify_ref to prettify_refname
>>   Prettify log decorations even more
>>   Fix test for new log decorate
>
> Shouldn't 2/3 and 3/3 just be squashed together? It looks like 3/3 fixes
> tests broken in 2/3, so you are hurting bisectability if they don't
> happen together.

Yeah, I thought so too. Maybe I should trust my instinct a bit more =P

> Other than that, I think the intent of the change and the implementation
> look fine.

Cool. I squashed them and re-sent.

-- 
Felipe Contreras