git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] log: prettier decorations

From
Jeff King <peff@peff.net>
Date
May 13, 2009, 21:28 UTC
Message-ID
<20090513212812.GA21268@coredump.intra.peff.net>
In-Reply-To
<1242249726-8514-1-git-send-email-felipe.contreras@gmail.com>
On Thu, May 14, 2009 at 12:22:03AM +0300, Felipe Contreras wrote:
> In order to do that I had to change prettify_ref to prettify_refname because
> add_ref_decoration doesn't have the ref object.
Thanks, this 1/3 looks fine to me.
But:
> Felipe Contreras (3):
>   Change prettify_ref to prettify_refname
>   Prettify log decorations even more
>   Fix test for new log decorate

Shouldn't 2/3 and 3/3 just be squashed together? It looks like 3/3 fixes tests broken in 2/3, so you are hurting bisectability if they don't happen together.

Other than that, I think the intent of the change and the implementation look fine.

-Peff
Previous: Felipe ContrerasNext: Felipe Contreras
Message 5 of 7 in “log: prettier decorations”
  1. 0/3 log: prettier decorationsFelipe Contreras, May 13, 2009
  2. 1/3 Change prettify_ref to prettify_refnameFelipe Contreras, May 13, 2009
  3. 2/3 Prettify log decorations even moreFelipe Contreras, May 13, 2009
  4. 3/3 Fix test for new log decorateFelipe Contreras, May 13, 2009
  5. Jeff KingMay 13, 2009
  6. 2/2 Prettify log decorations even moreFelipe Contreras, May 13, 2009
  7. Felipe ContrerasMay 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.