Re: [PATCH RESEND] Fix a bunch of pointer declarations (codestyle)
On Wed, Feb 25, 2009 at 10:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 40 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> This applies on top of the 'next' branch.
>>
>> alias.c | 4 +-
>> alloc.c | 2 +-
>> attr.c | 4 +-
>> builtin-blame.c | 8 +++---
>> builtin-checkout-index.c | 4 +-
>> builtin-describe.c | 4 +-
>> builtin-fetch-pack.c | 2 +-
>> builtin-help.c | 6 ++--
>> builtin-update-index.c | 6 ++--
>> cache.h | 2 +-
>> combine-diff.c | 4 +-
>> compat/mingw.c | 2 +-
>> config.c | 30 ++++++++++++++--------------
>> contrib/convert-objects/convert-objects.c | 6 ++--
>> diff-no-index.c | 2 +-
>> diff.c | 6 ++--
>> dir.c | 2 +-
>> fast-import.c | 14 ++++++------
>> git.c | 8 +++---
>> http.c | 4 +-
>> lockfile.c | 2 +-
>> reflog-walk.c | 2 +-
>> run-command.c | 2 +-
>> server-info.c | 4 +-
>> sha1_file.c | 2 +-
>> wt-status.c | 2 +-
>
> Sorry, but I cannot take this as is.
>
> These trivial clean-ups are welcome either as part of a preparatory
> clean-up before starting to work in the area of code you are touching, or
> as a standalone patch to files that nobody is currently working on.
>
> There is a huge overlap between "git diff --name-only master..pu" and the
> above list, so it is impossible for me to take the patch and I cannot
> afford the time to sift through gems out of stones.
It's understandable. Would there be a better time to send this patch?
After 1.6.2, or in a different form?
--
Felipe Contreras
Felipe Contreras <felipe.contreras@gmail.com>