git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RESEND] Fix a bunch of pointer declarations (codestyle)

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2009, 08:02 UTC
Message-ID
<7veixnaqrn.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1235512745-26814-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 28 quoted lines
> This applies on top of the 'next' branch.
>
>  alias.c                                   |    4 +-
>  alloc.c                                   |    2 +-
>  attr.c                                    |    4 +-
>  builtin-blame.c                           |    8 +++---
>  builtin-checkout-index.c                  |    4 +-
>  builtin-describe.c                        |    4 +-
>  builtin-fetch-pack.c                      |    2 +-
>  builtin-help.c                            |    6 ++--
>  builtin-update-index.c                    |    6 ++--
>  cache.h                                   |    2 +-
>  combine-diff.c                            |    4 +-
>  compat/mingw.c                            |    2 +-
>  config.c                                  |   30 ++++++++++++++--------------
>  contrib/convert-objects/convert-objects.c |    6 ++--
>  diff-no-index.c                           |    2 +-
>  diff.c                                    |    6 ++--
>  dir.c                                     |    2 +-
>  fast-import.c                             |   14 ++++++------
>  git.c                                     |    8 +++---
>  http.c                                    |    4 +-
>  lockfile.c                                |    2 +-
>  reflog-walk.c                             |    2 +-
>  run-command.c                             |    2 +-
>  server-info.c                             |    4 +-
>  sha1_file.c                               |    2 +-
>  wt-status.c                               |    2 +-
Sorry, but I cannot take this as is.

These trivial clean-ups are welcome either as part of a preparatory clean-up before starting to work in the area of code you are touching, or as a standalone patch to files that nobody is currently working on.

There is a huge overlap between "git diff --name-only master..pu" and the above list, so it is impossible for me to take the patch and I cannot afford the time to sift through gems out of stones.

Previous: Junio C HamanoNext: Felipe Contreras
Message 9 of 12 in “Fix a bunch of pointer declarations (codestyle)”
  1. Fix a bunch of pointer declarations (codestyle)Felipe Contreras, Feb 24, 2009
  2. git add: trivial codestyle cleanupFelipe Contreras, Feb 24, 2009
  3. git config: improve documentationFelipe Contreras, Feb 24, 2009
  4. sha1_file.c: fix typoFelipe Contreras, Feb 24, 2009
  5. Junio C HamanoFeb 25, 2009
  6. Johannes SchindelinFeb 25, 2009
  7. Felipe ContrerasMay 1, 2009
  8. Junio C HamanoFeb 25, 2009
  9. Junio C HamanoFeb 25, 2009
  10. Felipe ContrerasFeb 25, 2009
  11. Junio C HamanoFeb 25, 2009
  12. Felipe ContrerasMar 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.