Re: [PATCH B v4 1/5] git config: reorganize to use parseopt

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 22, 2009, 17:19 UTC
Message-ID: <94a0d4530902220919t729915dleed932b010ee76b@mail.gmail.com>
In-Reply-To: <7vskm62z9w.fsf@gitster.siamese.dyndns.org>

On Sun, Feb 22, 2009 at 6:48 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> +     else if (actions == ACTION_GET_COLORBOOL) {
>> +             if (argc == 1)
>> +                     stdout_is_tty = git_config_bool("command line", argv[0]);
>> +             else if (argc == 0)
>> +                     stdout_is_tty = isatty(1);
>> +             return get_colorbool(argc != 0);
>> +     }
>
> I see you fixed this from the last series...

Yes, argc != 1 was wrong. Now I've made sure all the tests pass.

-- 
Felipe Contreras