Re: [PATCH 1/2] fast-import: add special mode; copy from parent.

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Dec 22, 2008, 02:23 UTC
Message-ID: <94a0d4530812211823l78d86e1en8e19872ee7efef23@mail.gmail.com>
In-Reply-To: <20081221220757.GA17355@spearce.org>

On Mon, Dec 22, 2008 at 12:07 AM, Shawn O. Pearce <spearce@spearce.org> wrote:

Show 7 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> +     if (!prefixcmp(p, "- ")) {
>> +             mode = 0;
>> +             p += 2;
>
> This part made me wonder, why are we always doing "S_IFREG | mode"
> further down?

My guess is because 0644 and 0755; doing S_IFREG | mode doesn't achieve anything for the other modes.

I just sent a patch that I hope makes that more visible.

-- 
Felipe Contreras