git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] fast-import: add special '-' blob reference to use the previous one.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 21, 2008, 22:24 UTC
Message-ID
<7vlju9kvyg.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081221221149.GB17355@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 6 quoted lines
> Hmph, so if create a new path with a blob of "-" the repository
> will be corrupt because the zero id was used and error was produced.
>
> Actually I think you have the same bug in the prior patch with the
> mode being inherited.  I wonder if we shouldn't put error checking
> in too to validate that versions[0] describes a file entry.
Why are these patches necessary?

The proposed commit message describes what it does, but does not give hint to even guess being able to use this new feature helps in what situation. As far as I can see, these changes allow the exporter to say "this aspect of the new data is the same as the previous one", but I thought that the way in which fast-import works already revolves around "you have this tree, and the next tree is different from it in this and that way." Why does one need be able to mention "this is the same as the previous one" explicitly in the first place?

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 4 of 10 in “fast-import: add special mode; copy from parent.”
  1. 1/2 fast-import: add special mode; copy from parent.Felipe Contreras, Dec 21, 2008
  2. 2/2 fast-import: add special '-' blob reference to use the previous one.Felipe Contreras, Dec 21, 2008
  3. Shawn O. PearceDec 21, 2008
  4. Junio C HamanoDec 21, 2008
  5. Shawn O. PearceDec 21, 2008
  6. Felipe ContrerasDec 22, 2008
  7. Felipe ContrerasDec 22, 2008
  8. Shawn O. PearceDec 21, 2008
  9. Felipe ContrerasDec 22, 2008
  10. Felipe ContrerasDec 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.