AW: [EGIT] [PATCH RFC v1 5/5] Use the ignore patterns cache to determine ignores

Ferry,

I was just quickly hacking a rudimentary IgnoreRules class in jgit-core [1] mainly for the purpose of not forgetting about handling ignores finally ;)

I now saw you worked on introducing gitignore to EGIT, but wasn't able to find any repo with your code but only a few old patches. 

Do you see a way we can move your work into jgit-core? I've seen you have a lot of Eclipse specific stuff in your code, so we'd obviously have to cut those things in slices.

One possible strategy would be to make the IgnoreRules stuff in jgit-core contain only the 'readonly' evaluation code, thus no addIgnore(File) and addIgnore(String rule). Eclipse (or others, e.g. editor) could then manipulate the .gitignore files, and all the other ignore options and afterwards tells the IgnoreRules to re-initialise.

A second thing: Not looked at your code close enough, but I noticed that quite a few Eclipse plugins look at the subclipse when it comes to ignore handling, and try to 'hide' the ignore files from the user. I personally don't like that because the propset based ignore handling is a highly SVN specific thing. I prefer the way it's handled with the CVS plugin: show the .gitignore files to the user and even let him edit those files with an editor. As soon as we detect a change (even after a refresh if someone edited it with vi), we simply re-init our IgnoreRules.

WDYT?

Btw: Do you have a github account already? We could create an 'ignore' branch and I'm sure Jason can give you push rights to it. 

txs and LieGrue, strub

[1] http://github.com/sonatype/JGit/blob/ad8d1460919f1c5d34fff17a2ea54acea62e4107/org.spearce.jgit/src/org/spearce/jgit/ignore/IgnoreRules.java

--- Ferry Huberts <ferry.huberts@pelagic.nl> schrieb am Do, 26.3.2009:

[patch cutted]