Re: AW: [EGIT] [PATCH RFC v1 5/5] Use the ignore patterns cache to determine ignores

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: May 3, 2009, 13:17 UTC
Message-ID: <200905031517.33648.robin.rosenberg.lists@dewire.com>
In-Reply-To: <49FC401A.1030701@pelagic.nl>

lördag 02 maj 2009 14:44:10 skrev "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic.nl>:

Show 16 quoted lines

> Mark Struberg wrote:
> > Ferry,
> > 
> > I was just quickly hacking a rudimentary IgnoreRules class in jgit-core
> > [1] mainly for the purpose of not forgetting about handling ignores
> > finally ;)
> > 
> 
> I think there is no need to do that, I have that in my code already 
> (although in a different form). My implementation reflects what C git does.
> 
> > I now saw you worked on introducing gitignore to EGIT, but wasn't able
> > to find any repo with your code but only a few old patches.
> > 
> 
> it's in my local repo. I have no public repo

Perhaps you could send the patches if they are useful for review. I know Mark is anxious to get the patch train rolling.

If you do not want us to merge them yet add RFC to the subject prefix, though, I'm pretty sure we won't merge the first version anyway... Big or tricky patch sets rarely pass on the first attempt.

-- robin