Re: [PATCH v5 02/15] [GSOC] ref-filter: add %(raw) atom

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Jun 26, 2021, 00:42 UTC
Message-ID: <946c95bc-d57a-5b55-0dcf-5c4d6f980396@gmail.com>
In-Reply-To: <4e473838b9d2651a8e4be27332697c2ba354db5a.1624636945.git.gitgitgadget@gmail.com>

On 25/06/21 23.02, ZheNing Hu via GitGitGadget wrote:

Show 5 quoted lines

> Note that `--format=%(raw)` cannot be used with `--python`, `--shell`,
> `--tcl`, and `--perl` because if the binary raw data is passed to a
> variable in such languages, these may not support arbitrary binary data
> in their string variable type.
>

Commit message looks OK, but...

> +Note that `--format=%(raw)` can not be used with `--python`, `--shell`, `--tcl`,
> +`--perl` because the host language may not support arbitrary binary data in the
> +variables of its string type.
> +

Seems like out of sync between commit message and the docs change above. Did you mean the (unsupported) host languages are Python, BASH script, TCL/TK, and Perl respectively? If so, the docs should say:

"Note that `--format=%(raw) can not be used with `--python`, `--shell`, `-tcl`, and `--perl` because such languages may not support arbitrary binary data in their string variable type."

Thanks.

-- 
An old man doll... just what I always wanted! - Clara