Re: [PATCH v4 11/14] [GSOC] cat-file: change batch_objects parameter name
- From
Bagas Sanjaya <bagasdotme@gmail.com>
- Date
- Jun 24, 2021, 04:07 UTC
- Message-ID
- <88fc452c-77be-cfaa-0587-ed752049674b@gmail.com>
- In-Reply-To
- <069aa203666a4701e22078e9bc35a8c1ff4d5f15.1624332055.git.gitgitgadget@gmail.com>
On 22/06/21 10.20, ZheNing Hu via GitGitGadget wrote:
Show 8 quoted lines
> From: ZheNing Hu <adlternative@gmail.com> > > Since cat-file reuses ref-filter logic later will add the > formal parameter "const struct option *options" to > batch_objects(), the two synonymous parameters of "opt" > and "options" may confuse readers, so change batch_options > parameter of batch_objects() from "opt" to "batch". >
Better say "Because later cat-file reuses ref-filter logic that will add parameter ... ".
-- An old man doll... just what I always wanted! - Clara