Re: What's cooking in git.git (Nov 2018, #06; Wed, 21)

From: Matthew DeVore <matvore@comcast.net>
Date: Dec 5, 2018, 22:04 UTC
Message-ID: <93b57fe5-1cd4-9213-7183-47f695876615@comcast.net>
In-Reply-To: <xmqqlg5m7qlb.fsf@gitster-ct.c.googlers.com>

On 11/21/2018 01:00 AM, Junio C Hamano wrote:

Show 10 quoted lines

> * md/list-lazy-objects-fix (2018-10-29) 1 commit
>   - list-objects.c: don't segfault for missing cmdline objects
> 
>   "git rev-list --exclude-promissor-objects" had to take an object
>   that does not exist locally (and is lazily available) from the
>   command line without barfing, but the code dereferenced NULL.
> 
>   That sympotom may be worth addressing, but I think the "fix" is
>   overly broad and is wrong.  Giving a missing object should be
>   diagnosed as an error, not swept under the rug silently.

Thank you for taking a look. I just sent v3 of the patch: https://public-inbox.org/git/20181205214346.106217-1-matvore@google.com/T/#u

which is different from v2 in that it honors the presence or absence of --ignore-missing. It will only sweep things under the rug if that flag is passed.