Re: What's cooking in git.git (Nov 2018, #06; Wed, 21)

From: Jeff King <peff@peff.net>
Date: Nov 24, 2018, 12:06 UTC
Message-ID: <20181124120614.GA19257@sigill.intra.peff.net>
In-Reply-To: <xmqqefbb442v.fsf@gitster-ct.c.googlers.com>

On Sat, Nov 24, 2018 at 11:11:36AM +0900, Junio C Hamano wrote:

Show 11 quoted lines

> > However, note that the cache-load for finding abbreviations _must_ have
> > the complete list. And has been loading it for some time. So if you run
> > "git-fetch", for example, you've already been running this code for
> > months (and using the cache in more places is now a free speedup).
> >
> > At the very least, we'd want this patch on top, too. I also think René's
> > suggestion use access() is worth pursuing (though to some degree is
> > orthogonal to the cache).
> 
> OK, will queue, but I wonder where 66f0 comes from before silently
> doing s/66f04152be/3a2e08245c/ myself.

Whoops, I thought I made double-sure to pull the commit id from origin/jk/loose-object-cache instead of my original local commits, but obviously I didn't. Thanks for catching it.

-Peff