git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir: allow exclusions from blob in addition to file

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Oct 27, 2017, 15:02 UTC
Message-ID
<937c3ec0-fb9b-0f11-b00d-f015d8e4bf4b@jeffhostetler.com>
In-Reply-To
<xmqq8tfxe693.fsf@gitster.mtv.corp.google.com>
On 10/26/2017 9:20 PM, Junio C Hamano wrote:
Show 25 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Refactor add_excludes() to separate the reading of the
>> exclude file into a buffer and the parsing of the buffer
>> into exclude_list items.
>>
>> Add add_excludes_from_blob_to_list() to allow an exclude
>> file be specified with an OID without assuming a local
>> worktree or index exists.
>>
>> Refactor read_skip_worktree_file_from_index() and add
>> do_read_blob() to eliminate duplication of preliminary
>> processing of blob contents.
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> ---
> 
> Yeah, with a separate do_read_blob() helper, this one looks a lot
> easier to follow, at least to me---as the author, you might find the
> earlier one just as easy, I suspect, though ;-)
> 
> Thanks.  Will queue.
> 

Yeah, I think the net result is better and easier to follow. Thanks, Jeff

Previous: Junio C Hamano
Message 4 of 4 in “dir: allow exclusions from blob in addition to file”
  1. dir: allow exclusions from blob in addition to fileJeff Hostetler, Oct 26, 2017
  2. dir: allow exclusions from blob in addition to fileJeff Hostetler, Oct 26, 2017
  3. Junio C HamanoOct 27, 2017
  4. Jeff HostetlerOct 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.