From: Jeff Hostetler <git@jeffhostetler.com>
Date: Fri, 27 Oct 2017 15:02:40 GMT
Subject: Re: [PATCH] dir: allow exclusions from blob in addition to file
Message-ID: <937c3ec0-fb9b-0f11-b00d-f015d8e4bf4b@jeffhostetler.com>
In-Reply-To: <xmqq8tfxe693.fsf@gitster.mtv.corp.google.com>



On 10/26/2017 9:20 PM, Junio C Hamano wrote:
> Jeff Hostetler <git@jeffhostetler.com> writes:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Refactor add_excludes() to separate the reading of the
>> exclude file into a buffer and the parsing of the buffer
>> into exclude_list items.
>>
>> Add add_excludes_from_blob_to_list() to allow an exclude
>> file be specified with an OID without assuming a local
>> worktree or index exists.
>>
>> Refactor read_skip_worktree_file_from_index() and add
>> do_read_blob() to eliminate duplication of preliminary
>> processing of blob contents.
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> ---
> 
> Yeah, with a separate do_read_blob() helper, this one looks a lot
> easier to follow, at least to me---as the author, you might find the
> earlier one just as easy, I suspect, though ;-)
> 
> Thanks.  Will queue.
> 

Yeah, I think the net result is better and easier to follow.
Thanks,
Jeff