git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 1/2] t6300: test sort with multiple keys

From
Kacper Kornet <draenog@pld-linux.org>
Date
Aug 21, 2012, 07:46 UTC
Message-ID
<91678e1e50f23bdb2c3b2c5716f92d870a233e77.1345534654.git.draenog@pld-linux.org>
In-Reply-To
<7vk3wuo0sa.fsf@alter.siamese.dyndns.org>

Documentation of git-for-each-ref says that --sort=<key> option can be used multiple times, in which case the last key becomes the primary key. However this functionality was never checked in test suite and is currently broken. This commit adds appropriate test in preparation for fix.

Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
---
 t/t6300-for-each-ref.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
index 1721784..a0d82d4 100755
--- a/t/t6300-for-each-ref.sh
+++ b/t/t6300-for-each-ref.sh
@@ -456,4 +456,14 @@ test_atom refs/tags/signed-long contents "subject line
 body contents
 $sig"
 
+cat >expected <<\EOF
+408fe76d02a785a006c2e9c669b7be5589ede96d <committer@example.com> refs/tags/master
+90b5ebede4899eda64893bc2a4c8f1d6fb6dfc40 <committer@example.com> refs/tags/bogo
+EOF
+
+test_expect_failure 'Verify sort with multiple keys' '
+	git for-each-ref --format="%(objectname) %(taggeremail) %(refname)" --sort=objectname --sort=taggeremail \
+		refs/tags/bogo refs/tags/master > actual &&
+	test_cmp expected actual
+'
 test_done
-- 
1.7.12.rc3


-- 
  Kacper Kornet
Previous: Kacper KornetNext: Kacper Kornet
Message 6 of 8 in “t6300: test sort with multiple keys”
  1. 1/2 t6300: test sort with multiple keysKacper Kornet, Aug 19, 2012
  2. 2/2 for-each-ref: Fix sort with multiple keysKacper Kornet, Aug 19, 2012
  3. Junio C HamanoAug 20, 2012
  4. Junio C HamanoAug 20, 2012
  5. Kacper KornetAug 20, 2012
  6. 1/2 t6300: test sort with multiple keysKacper Kornet, Aug 21, 2012
  7. 2/2 for-each-ref: Fix sort with multiple keysKacper Kornet, Aug 21, 2012
  8. Junio C HamanoAug 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.