git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] for-each-ref: Fix sort with multiple keys

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2012, 00:41 UTC
Message-ID
<7vfw7io0ny.fsf@alter.siamese.dyndns.org>
In-Reply-To
<2b3624458d79a1ec0b1437172437fbd78b3a0537.1345410836.git.draenog@pld-linux.org>
Kacper Kornet <draenog@pld-linux.org> writes:
Show 23 quoted lines
> The linked list describing sort options was not correctly set up in
> opt_parse_sort. In the result, contrary to the documentation. only the
> last of multiple --sort options to git-for-each-ref was taken into
> account. This commit fixes it.
>
> Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
> ---
>  builtin/for-each-ref.c  | 4 +++-
>  t/t6300-for-each-ref.sh | 2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index b01d76a..0c5294e 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -962,7 +962,9 @@ static int opt_parse_sort(const struct option *opt, const char *arg, int unset)
>  	if (!arg) /* should --no-sort void the list ? */
>  		return -1;
>  
> -	*sort_tail = s = xcalloc(1, sizeof(*s));
> +	s = xcalloc(1, sizeof(*s));
> +	s->next = *sort_tail;
> +	*sort_tail = s;
This fix looks correct.  
Previous: Kacper KornetNext: Junio C Hamano
Message 3 of 8 in “t6300: test sort with multiple keys”
  1. 1/2 t6300: test sort with multiple keysKacper Kornet, Aug 19, 2012
  2. 2/2 for-each-ref: Fix sort with multiple keysKacper Kornet, Aug 19, 2012
  3. Junio C HamanoAug 20, 2012
  4. Junio C HamanoAug 20, 2012
  5. Kacper KornetAug 20, 2012
  6. 1/2 t6300: test sort with multiple keysKacper Kornet, Aug 21, 2012
  7. 2/2 for-each-ref: Fix sort with multiple keysKacper Kornet, Aug 21, 2012
  8. Junio C HamanoAug 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.