Re: [PATCH v2 3/3] commit: use prio_queue_replace() in pop_most_recent_commit(),MIME-Version: 1.0

From: René Scharfe <l.s.r@web.de>
Date: Aug 3, 2025, 11:33 UTC
Message-ID: <90d4a2c7-70a1-4bf2-85e4-9821b55cdde7@web.de>
In-Reply-To: <0d3ddfcc-485e-45cb-28e6-62108e6d5a4d@gmx.de>

On 8/3/25 1:12 PM, Johannes Schindelin wrote:

Show 16 quoted lines

> Hi René,
> 
> On Fri, 18 Jul 2025, René Scharfe wrote:
> 
>> Optimize pop_most_recent_commit() by adding the first parent using the
>> more efficient prio_queue_peek() and prio_queue_replace() instead of
>> prio_queue_get() and prio_queue_put().
>>
>> [... clipped ...]
> 
> I noticed that v2 of this patch not only made it into `next`, but it also
> introduced a commit subject suffix (likely unintended?):
> 
>   [PATCH v2 3/3] commit: use prio_queue_replace() in pop_most_recent_commit(),MIME-Version: 1.0
> 
> Maybe that is something you want to look into?

My bad, copy+paste error. A fixed version made it into master in the meantime. Sorry about that, and thanks a lot for correcting it, Junio!

René