Re: [PATCH 0/3] commit: convert pop_most_recent_commit() to prio_queue

From: Jeff King <peff@peff.net>
Date: Jul 19, 2025, 06:45 UTC
Message-ID: <20250719064516.GC705356@coredump.intra.peff.net>
In-Reply-To: <5a25d830-0825-4b28-8763-2be342d2b6a3@web.de>

On Wed, Jul 16, 2025 at 11:38:39AM +0200, René Scharfe wrote:

Show 8 quoted lines

> Yes, commit_list_insert_by_date() is stable, as it inserts commits after
> ones with the same date.  Items are popped from the top, so this ensures
> FIFO behavior for commits with the same date.
> 
> prio_queue ensures stability using an ID and favors lower ones, so it
> provides the same order.
> 
> We should add unit tests for that, no?

Probably wouldn't hurt to do so, but I don't think doing so needs to hold up your series.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.