Re: [PATCH 1/2] t/lib-http.sh: Restructure finding of default httpd location
- From
- Tarmigan <tarmigan+git@gmail.com>
- Date
- Nov 20, 2009, 03:30 UTC
- Message-ID
- <905315640911191930rc33cabdr290b534ffbe85690@mail.gmail.com>
- In-Reply-To
- <76718490911191914n23d067b8teb17907de9ec83d5@mail.gmail.com>
On Thu, Nov 19, 2009 at 7:14 PM, Jay Soffian <jaysoffian@gmail.com> wrote:
Show 11 quoted lines
> On Thu, Nov 19, 2009 at 8:22 PM, Tarmigan Casebolt > <tarmigan+git@gmail.com> wrote: >> uname might not be the best way to determine the default location for >> httpd since different Linux distributions apparently put httpd in >> different places, so we test a couple different locations for httpd, >> and use the first one that we come across. We do the same for the >> modules directory. > > Perhaps testing the distribution and looking in the known location for > that distribution then? That said, going through a list of well known > locations should work too.
Is there a nice way to test the distribution? Seems to me like doing that might be more complicated and also more fragile.
Show 8 quoted lines
>> +for DEFAULT_HTTPD_PATH in '/usr/sbin/httpd' '/usr/sbin/apache2' >> +do >> + test -x "$DEFAULT_HTTPD_PATH" && break >> +done > > Unfortunately this leaves DEFAULT_HTTPD_PATH as the last item in the > list even if the test does not pass. You can add an empty item to the > end of the list if you want to do this way.
Yes. I think this is how it was before though too, and it is caught later in the script with the LIB_HTTPD_PATH setting and testing.
Show 9 quoted lines
>> +for DEFAULT_HTTPD_MODULE_PATH in '/usr/libexec/apache2' \ >> + '/usr/lib/apache2/modules' \ >> + '/usr/lib64/httpd/modules' \ >> + '/usr/lib/httpd/modules' >> +do >> + test -d "$DEFAULT_HTTPD_MODULE_PATH" && break >> +done > > Ditto.
Yes. Again, this is still more thorough than before, but in this case the script does not check later. Perhaps the script should test this value and test_done if it's not a directory?
Thanks, Tarmigan