Re: [PATCH 2/2] t/lib-http.sh: Enable httpd tests by default.

From: Clemens Buchacher <drizzd@aon.at>
Date: Nov 20, 2009, 20:11 UTC
Message-ID: <20091120201116.GA19131@localhost>
In-Reply-To: <905315640911201103w6d1da86duf41a53537672be8e@mail.gmail.com>

On Fri, Nov 20, 2009 at 11:03:13AM -0800, Tarmigan wrote:

> Here's a patch (cut-n-paste so it will probably be munged) for
> discussion of the port-fallback idea.  If httpd cannot bind to 5541,
> it tries 15541 etc.

I would prefer if we skip the test right away. If we really want to try different ports, we should first check that the port really is the problem. Otherwise, the test will uselessly retry several times. Apache 2 writes

 (98)Address already in use: make_sock: could not bind to address
 127.0.0.1:5541

to stderr, which we could use to detect that error condition. But other web servers are bound to behave differently.

Clemens