Re: [PATCH v3 00/10] Optimization batch 8: use file basenames even more
On 2/25/2021 8:58 PM, Elijah Newren via GitGitGadget wrote:
Show 9 quoted lines
> This series depends on en/diffcore-rename (a concatenation of what I was
> calling ort-perf-batch-6 and ort-perf-batch-7).
>
> Changes since v2:
>
> * Rearrange the patches in the series to have a top-down ordering rather
> than bottom-up -- as suggested by Stolee, Ævar, and Junio
> * Several comments and style improvements suggested by Stolee
> * Replace xstrfmt() with a few strbuf_add*() calls, as suggested by Stolee
I like the new layout. The code looks good. The only nit I have is that
some of the old commit messages read awkwardly with the new ordering.
These are not critical, so this version gets my:
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Derrick Stolee <stolee@gmail.com>